Skip to content

Simplify collectFields for @defer & @stream #3982

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Simplify collectFields for @defer & @stream #3982

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a2adbc1
Simplify collectFields for @defer & @stream
robrichard Nov 6, 2023
9472777
no need to save ancestors (#2)
yaacovCR Nov 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions src/execution/IncrementalPublisher.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import type {
GraphQLFormattedError,
} from '../error/GraphQLError.js';

import type { GroupedFieldSet } from './collectFields.js';
import type { DeferUsage, GroupedFieldSet } from './collectFields.js';

interface IncrementalUpdate<TData = unknown, TExtensions = ObjMap<unknown>> {
pending: ReadonlyArray<PendingResult>;
Expand Down Expand Up @@ -786,6 +786,7 @@ export class DeferredGroupedFieldSetRecord {
/** @internal */
export class DeferredFragmentRecord {
path: ReadonlyArray<string | number>;
deferUsage: DeferUsage;
label: string | undefined;
id: string | undefined;
children: Set<SubsequentResultRecord>;
Expand All @@ -795,9 +796,10 @@ export class DeferredFragmentRecord {
pendingSent?: boolean;
_pending: Set<DeferredGroupedFieldSetRecord>;

constructor(opts: { path: Path | undefined; label: string | undefined }) {
constructor(opts: { path: Path | undefined; deferUsage: DeferUsage }) {
this.path = pathToArray(opts.path);
this.label = opts.label;
this.label = opts.deferUsage.label;
this.deferUsage = opts.deferUsage;
this.children = new Set();
this.filtered = false;
this.deferredGroupedFieldSetRecords = new Set();
Expand Down
Loading