Skip to content

Reject deprecated fields when interface field is not deprecated #3986

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Parent: index.md
merged 4 commits into from
Mar 8, 2025
Merged

Reject deprecated fields when interface field is not deprecated #3986

merged 4 commits into from
Mar 8, 2025

Conversation

@benjie
Copy link
Member

@benjie benjie commented Nov 9, 2023

This PR implements GraphQL RFC graphql/graphql-spec#1053; please see that PR for details.

@benjie benjie added the spec RFC Implementation of a proposed change to the GraphQL specification label Nov 9, 2023
@netlify
Copy link

netlify bot commented Nov 9, 2023 •
edited
Loading

✅ Deploy Preview for compassionate-pike-271cb3 ready!

Name Link
🔨 Latest commit ef0f892
🔍 Latest deploy log https://app.netlify.com/sites/compassionate-pike-271cb3/deploys/67530f3b5a95220008251429
😎 Deploy Preview https://deploy-preview-3986--compassionate-pike-271cb3.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@benjie benjie mentioned this pull request Nov 9, 2023
Closed
@github-actions
Copy link

github-actions bot commented Nov 9, 2023

Hi @benjie, I'm @github-actions bot happy to help you with this PR 👋

Supported commands

Please post this commands in separate comments and only one per comment:

  • @github-actions run-benchmark - Run benchmark comparing base and merge commits for this PR
  • @github-actions publish-pr-on-npm - Build package from this PR and publish it on NPM

@benjie benjie mentioned this pull request Nov 28, 2024
Merged
leebyron
leebyron approved these changes Dec 5, 2024
View reviewed changes
benjie
benjie commented Dec 6, 2024
View reviewed changes
@benjie benjie mentioned this pull request Feb 27, 2025
Open
17 tasks
@benjie benjie requested a review from a team as a code owner March 7, 2025 16:40
JoviDeCroock
JoviDeCroock approved these changes Mar 8, 2025
View reviewed changes
@JoviDeCroock JoviDeCroock merged commit 85066a0 into main Mar 8, 2025
29 checks passed
@JoviDeCroock JoviDeCroock deleted the interface-deprecated-field-consistency branch April 24, 2025 13:18
@yaacovCR yaacovCR added PR: feature 🚀 requires increase of "minor" version number PR: breaking change 💥 implementation requires increase of "major" version number and removed PR: feature 🚀 requires increase of "minor" version number labels Jun 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@leebyron leebyron leebyron approved these changes

@JoviDeCroock JoviDeCroock JoviDeCroock approved these changes

@saihaj saihaj saihaj approved these changes

Assignees

No one assigned

Labels

PR: breaking change 💥 implementation requires increase of "major" version number spec RFC Implementation of a proposed change to the GraphQL specification

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@benjie @leebyron @JoviDeCroock @saihaj @yaacovCR