fix(validation): catch OverlappingFieldsCanBeMergedRule violations with nested fragments#4168

Merged

yaacovCR merged 9 commits intographql:16.x.xfrom

sachindshinde:fix-16.3.0-OverlappingFieldsCanBeMergedRule

Sep 23, 2024

Commits on Sep 23, 2024

Add test that elicits bug with comparedFragmentPairs usage

sachindshinde
authored and
yaacovCR
committed
Revert non-test changes in https://github.com/graphql/graphql-js/pull/3442 , which introduced the bugged compareFragmentPairs usage

sachindshinde
authored and
yaacovCR
committed
Modify collectConflictsBetweenFieldsAndFragment() to track seen fragments when recursing into fragments (but not when recursing into fields, to save memory)

sachindshinde
authored and
yaacovCR
committed
Add test that elicits bug caused by not recursing into fields

sachindshinde
authored and
yaacovCR
committed
Revert previous changes for collectConflictsBetweenFieldsAndFragment() in light of bug

sachindshinde
authored and
yaacovCR
committed
Modify comparedFragmentPairs to allow a selection set to replace a fragment, and modify collectConflictsBetweenFieldsAndFragment() to memoize the selection set and fragment

sachindshinde
authored and
yaacovCR
committed
Separate fields-fragment memoization from fragment-fragment memoization

sachindshinde
and
yaacovCR
committed
introduce OrderedPairSet class
yaacovCR
committed
remove custom comparator option
yaacovCR
committed