Skip to content

chore(workspace): lint and format on commit #4217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Parent: index.md
merged 1 commit into from
Oct 7, 2024
Merged

chore(workspace): lint and format on commit #4217

merged 1 commit into from
Oct 7, 2024

Conversation

@JoviDeCroock
Copy link
Member

Personally have been really annoyed with the lack of pre-commit in this repository, I have to commit twice every time as I'm not used to manually calling npm run lint && npm run format

@JoviDeCroock JoviDeCroock requested a review from a team as a code owner October 7, 2024 11:03
@netlify
Copy link

netlify bot commented Oct 7, 2024 •
edited
Loading

✅ Deploy Preview for compassionate-pike-271cb3 ready!

Name Link
🔨 Latest commit c6ebed0
🔍 Latest deploy log https://app.netlify.com/sites/compassionate-pike-271cb3/deploys/6703e80767b47600085cf1e2
😎 Deploy Preview https://deploy-preview-4217--compassionate-pike-271cb3.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions
Copy link

github-actions bot commented Oct 7, 2024

Hi @JoviDeCroock, I'm @github-actions bot happy to help you with this PR 👋

Supported commands

Please post this commands in separate comments and only one per comment:

  • @github-actions run-benchmark - Run benchmark comparing base and merge commits for this PR
  • @github-actions publish-pr-on-npm - Build package from this PR and publish it on NPM

@JoviDeCroock JoviDeCroock added the PR: polish 💅 PR doesn't change public API or any observed behaviour label Oct 7, 2024
yaacovCR
yaacovCR approved these changes Oct 7, 2024
View reviewed changes
Copy link
Contributor

@yaacovCR yaacovCR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on my local machine, and prevents me from unhealthy committing. :) I added some thoughts to consider, but it could always be done in a later PR.

@JoviDeCroock JoviDeCroock merged commit 0ce8cc8 into main Oct 7, 2024
34 checks passed
@JoviDeCroock JoviDeCroock deleted the add-pre-commit branch October 7, 2024 14:19
@yaacovCR yaacovCR mentioned this pull request Oct 7, 2024
Merged
@yaacovCR yaacovCR added PR: internal 🏠 and removed PR: polish 💅 PR doesn't change public API or any observed behaviour labels Oct 7, 2024
@jasonkuhrt jasonkuhrt mentioned this pull request Oct 29, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yaacovCR yaacovCR yaacovCR approved these changes

Assignees

No one assigned

Labels

PR: internal 🏠

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@JoviDeCroock @yaacovCR