Skip to content

Conversation

@JoviDeCroock
Copy link
Member

Closes #3853

There's only one normalizedConfig we export and these are just the type config with a few extras. I would rather than exporting all of them just stop exporting them for the time being as we don't accept them as inputs and it can still be derived by doing ReturnType<GraphQLInterfaceType['toConfig']> if it's really needed

@JoviDeCroock JoviDeCroock requested a review from a team as a code owner October 13, 2024 14:09
@netlify
Copy link

netlify bot commented Oct 13, 2024

Deploy Preview for compassionate-pike-271cb3 ready!

Name Link
🔨 Latest commit a172878
🔍 Latest deploy log https://app.netlify.com/sites/compassionate-pike-271cb3/deploys/670bd485d107100008575ca6
😎 Deploy Preview https://deploy-preview-4227--compassionate-pike-271cb3.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions
Copy link

Hi @JoviDeCroock, I'm @github-actions bot happy to help you with this PR 👋

Supported commands

Please post this commands in separate comments and only one per comment:

  • @github-actions run-benchmark - Run benchmark comparing base and merge commits for this PR
  • @github-actions publish-pr-on-npm - Build package from this PR and publish it on NPM

@JoviDeCroock JoviDeCroock added PR: polish 💅 PR doesn't change public API or any observed behaviour PR: breaking change 💥 implementation requires increase of "major" version number and removed PR: polish 💅 PR doesn't change public API or any observed behaviour labels Oct 13, 2024
@JoviDeCroock JoviDeCroock merged commit 89f23d1 into main Oct 13, 2024
35 checks passed
@yaacovCR yaacovCR deleted the remove-interface-normalized-export branch October 27, 2024 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR: breaking change 💥 implementation requires increase of "major" version number

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants