use object for GraphQLWrappedResult instead of tuple #4265
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for readability. benchmarks suggest similar performance
yaacovCR
changed the title
✅ Deploy Preview for compassionate-pike-271cb3 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
yaacovCR
added
the
PR: polish 💅
|
Hi @yaacovCR, I'm @github-actions bot happy to help you with this PR 👋 Supported commandsPlease post this commands in separate comments and only one per comment:
|
yaacovCR
requested review from
JoviDeCroock and
robrichard
and removed request for
a team
JoviDeCroock
approved these changes
Oct 29, 2024
There was a problem hiding this comment.
The reason for this performance improvement is that multi-value-shape tuples and especially holey tuples are a deopt.
- First deopt --> the Array is not mono-value i.e. we can have T and nested arrays as well as an explicit undefined
- Second deopt --> the second array can be an explicit undefined (a hole)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for readability. benchmarks suggest similar or even better performance