Skip to content

Minor validation tweaks from review #4407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 27, 2025
Merged

Minor validation tweaks from review #4407

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/type/validate.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -812,7 +812,7 @@ function createInputObjectDefaultValueCircularRefsValidator(
): void {
// Start with an empty object as a way to visit every field in this input
// object type and apply every default value.
return detectValueDefaultValueCycle(inputObj, {});
return detectValueDefaultValueCycle(inputObj, Object.create(null));
};

function detectValueDefaultValueCycle(
Expand Down Expand Up @@ -910,7 +910,7 @@ function createInputObjectDefaultValueCircularRefsValidator(

// Check to see if there is cycle.
const cycleIndex = fieldPathIndex[fieldStr];
if (cycleIndex !== undefined && cycleIndex > 0) {
if (cycleIndex !== undefined) {
context.reportError(
`Invalid circular reference. The default value of Input Object field ${fieldStr} references itself${
cycleIndex < fieldPath.length
Expand Down
Loading