chore: drop unsupported node versions #4447
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yaacovCR
added
the
PR: breaking change 💥
benjie
approved these changes
Jul 2, 2025
Co-authored-by: Benjie <[email protected]>
yaacovCR
added a commit
to yaacovCR/graphql-js
that referenced
this pull request
Jul 30, 2025
we will test only versions that are not EOL: i.e. 20, 22, 24, and update the engines field to give warnings on anything other than those versions. we may further choose to require minimum subversions of 20, 22, and 24 that enable require(esm), but this PR holds off on that just yet. --------- Co-authored-by: Benjie <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we will test only versions that are not EOL: i.e. 20, 22, 24, and update the engines field to those same versions
give warnings on anything below 20.we may further choose to require minimum subversions of 20, 22, and 24 that enable require(esm), but this PR holds off on that just yet.