avoid re-visiting deferred fragment spreads #4462
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR changes the fragment spread visiting logic to avoid re-visiting fragment spreads whenever possible. Previously, fragment spreads that have been visited in a non-deferred capacity were not revisited, but fragment spreads that had been visited in a deferred capacity could be revisited. This PR updates the logic so that fragment spreads that had been visited in a deferred capacity are not revisited in a deferred capacity. See graphql/graphql-spec#1045 (comment)
yaacovCR
added
PR: bug fix 🐞
robrichard
approved these changes
Jul 23, 2025
yaacovCR
added a commit
to yaacovCR/graphql-js
that referenced
this pull request
Jul 30, 2025
This PR changes the fragment spread visiting logic to avoid re-visiting fragment spreads in additional cases. Previously, fragment spreads that have been visited in a non-deferred capacity were not revisited, but fragment spreads that had been visited in a deferred capacity could be revisited. This PR updates the logic so that fragment spreads that had been visited in a deferred capacity are not revisited in a deferred capacity. See: graphql/graphql-spec#1045 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the fragment spread visiting logic to avoid re-visiting fragment spreads whenever possible.
Previously, fragment spreads that have been visited in a non-deferred capacity were not revisited, but fragment spreads that had been visited in a deferred capacity could be revisited.
This PR updates the logic so that fragment spreads that had been visited in a deferred capacity are not revisited in a deferred capacity.
See graphql/graphql-spec#1045 (comment)
@benjie @robrichard