Add definitions to the style guide #1137
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for graphql-spec-draft ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
benjie
requested changes
Feb 25, 2025
Member
benjie
left a comment
benjie
left a comment
There was a problem hiding this comment.
@martinbonnin Please split this into two PRs, the definitions can easily be merged, but I think we should ask the editor to approve the tone of voice section.
Co-authored-by: Benjie <[email protected]>
Merged
Contributor
Author
benjie
approved these changes
Feb 25, 2025
Member
benjie
left a comment
benjie
left a comment
There was a problem hiding this comment.
They also automatically link all italicised references to the term.
martinbonnin
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ping @benjie, @robrichard