-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Service capabilities / error behaviors #1163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from 3 commits
31c90e7
f4fab96
692d811
94446ab
3c63355
7056690
0fa7a33
1f975e4
8c40086
641a786
026982b
a7c6ad5
fe559ea
b5f64ae
1c3f0cd
7ab36b8
cc50991
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -131,6 +131,7 @@ type __Schema { | |
mutationType: __Type | ||
subscriptionType: __Type | ||
directives: [__Directive!]! | ||
defaultErrorBehavior: __ErrorBehavior! | ||
} | ||
|
||
type __Type { | ||
|
@@ -164,6 +165,12 @@ enum __TypeKind { | |
NON_NULL | ||
} | ||
|
||
enum __ErrorBehavior { | ||
NO_PROPAGATE | ||
PROPAGATE | ||
ABORT | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Moving my previous comment here, love this proposal overall but I would love it even more with enum __ErrorBehavior {
NULL
PROPAGATE
ABORT
} tldr: I believe this is going to be read and discussed a lot more than it's going to be written by users and I would optimize for the conciseness, pronouncability and memorability of There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. To summarize my thoughts on it from the previous thread: Communication issuesIf you tell someone on the phone to set Ambiguity issues
Errors already become null in the spec:
Please suggest other alternatives!I'm very open to changing the word I've gone through about 30 alternatives when brainstorming it, and none are sufficiently clear whilst also being shorter than There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Ooo... Maybe |
||
} | ||
|
||
type __Field { | ||
name: String! | ||
description: String | ||
|
@@ -238,6 +245,11 @@ Fields\: | |
must be included in this set. | ||
- `directives` must return the set of all directives available within this | ||
schema including all built-in directives. | ||
- `defaultErrorBehavior` must return the _default error behavior_ of the schema | ||
using one of the values of the `__ErrorBehavior` enum: | ||
- {"NO_PROPAGATE"} | ||
- {"PROPAGATE"} | ||
- {"ABORT"} | ||
|
||
### The \_\_Type Type | ||
|
||
|
Uh oh!
There was an error while loading. Please reload this page.