-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Update description of Fragments to emphasize evolving data needs #1193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
janettec
wants to merge
4
commits into
graphql:main
Choose a base branch
from
janettec:fragment-usage
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+17
−12
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -587,13 +587,12 @@ FragmentName : Name but not `on` | |
|
||
Fragments are the primary unit of composition in GraphQL. | ||
|
||
Fragments allow for the reuse of common repeated selections of fields, reducing | ||
duplicated text in the document. Inline Fragments can be used directly within a | ||
selection to condition upon a type condition when querying against an interface | ||
or union. | ||
Fragments allow for the definition of modular selection sets that make it easier | ||
to add and remove selections as needed. | ||
Comment on lines
+590
to
+591
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Maybe something along the lines of (written whilst on Zoom, not final wording!):
|
||
|
||
For example, if we wanted to fetch some common information about mutual friends | ||
as well as friends of some user: | ||
For example, if we have some `friendProfile` logic that requires `id`, `name`, | ||
and `profilePic`, and we want to apply that logic to the mutual friends as well | ||
as friends of some user: | ||
|
||
```graphql example | ||
query noFragments { | ||
|
@@ -612,29 +611,35 @@ query noFragments { | |
} | ||
``` | ||
|
||
The repeated fields could be extracted into a fragment and composed by a parent | ||
fragment or operation. | ||
The fields required by `friendProfile` can be extracted into a fragment and | ||
benjie marked this conversation as resolved.
Show resolved
Hide resolved
|
||
composed by a parent fragment or operation. | ||
|
||
```graphql example | ||
query withFragments { | ||
user(id: 4) { | ||
friends(first: 10) { | ||
...friendFields | ||
...friendProfile | ||
} | ||
mutualFriends(first: 10) { | ||
...friendFields | ||
...friendProfile | ||
} | ||
} | ||
} | ||
``` | ||
|
||
"Common fields for a user's friends." | ||
fragment friendFields on User { | ||
```graphql example | ||
"Fields required to display a friend's profile" | ||
fragment friendProfile on User { | ||
id | ||
name | ||
profilePic(size: 50) | ||
} | ||
``` | ||
|
||
If `friendProfile` no longer needs `name`, the `name` field can be removed from | ||
benjie marked this conversation as resolved.
Show resolved
Hide resolved
|
||
the `friendProfile` fragment and it will no longer be fetched in both locations | ||
the fragment is consumed. | ||
|
||
Fragments are consumed by using the spread operator (`...`). All fields selected | ||
by the fragment will be added to the field selection at the same level as the | ||
fragment invocation. This happens through multiple levels of fragment spreads. | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to flush out what modular means. Matt + Pascal's suggestion: single purpose.