Skip to content

fix: field selection set final values#1212

Open
MarkoMin wants to merge 4 commits intographql:mainfrom
MarkoMin:fix/field_selection
Open

fix: field selection set final values#1212
MarkoMin wants to merge 4 commits intographql:mainfrom
MarkoMin:fix/field_selection

Conversation

@MarkoMin
Copy link

AFAIK scalar and enum values are considered to be distinct throughout the specification so I think this would be more correct description of field selection.

I didn't change the sentence below the modified one because it doesn't contain any enum values, but I may add some if that'd be beneficial.

It really is a nitpick, but I stopped on it while reading the spec.

@netlify
Copy link

netlify bot commented Feb 24, 2026

Deploy Preview for graphql-spec-draft ready!

Name Link
🔨 Latest commit 0ecb37c
🔍 Latest deploy log https://app.netlify.com/projects/graphql-spec-draft/deploys/69aea44539fd1800084ec914
😎 Deploy Preview https://deploy-preview-1212--graphql-spec-draft.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Feb 24, 2026

CLA Signed

The committers listed above are authorized under a signed CLA.

Copy link
Member

@benjie benjie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have the concept of "leaf fields" and "leaf values" already (though it is introduced later in the spec), maybe we should reference that here instead. One concern at the moment is the current wording doesn't handle lists of scalars/enums (or lists of those lists!).

It's still better than what we currently have though; thanks for the contribution!

@benjie benjie added ✏️ Editorial PR is non-normative or does not influence implementation 🚀 Next Stage? This RFC believes it is ready for the next stage labels Feb 26, 2026
@martinbonnin
Copy link
Contributor

I've pre-emptively added this to the April wg: graphql/graphql-wg#1947
@MarkoMin feel free to add yourself to the agenda

@MarkoMin
Copy link
Author

MarkoMin commented Mar 9, 2026

Sorry, I forgot formatting. Now tests should pass.

@martinbonnin
Copy link
Contributor

Thanks! For the record, I'm not sure this requires a working group item, I'm fine to merge this async. I mostly added it as a forcing function to review this PR if we haven't acted by then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

✏️ Editorial PR is non-normative or does not influence implementation 🚀 Next Stage? This RFC believes it is ready for the next stage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants