Clarify current ResolveAbstractType algorithm#973
Clarify current ResolveAbstractType algorithm#973yaacovCR wants to merge 4 commits intographql:mainfrom
Conversation
✅ Deploy Preview for graphql-spec-draft ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
This PR attempts to clarify the current behavior. It can be seen as a prelude to #960 (which loosens the return type of the internal type system method to allow returning a transitive interface) -- but this PR might also be a helpful addition on its own. |
benjie
left a comment
benjie
left a comment
There was a problem hiding this comment.
Some bike-shedding suggestions 😅
Motivation: IsSubType could be re-used in graphql#973
Motivation: IsSubType could be re-used in #973
|
Merged the dependent editorial change so you can use that change here. This feels like a real ambiguity in the spec that's getting resolved, nice catch! Can we confirm that these assertions already align to existing GraphQL.js behavior? |
|
This change is meant to capture existing behavior in graphql-js: see fn ensureValidRuntimeType @ |
|
@graphql/tsc ready for review |
|
pinging @graphql/tsc on this |
✅ Deploy Preview for graphql-spec-draft ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
add assertions from reference implementation
Co-authored-by: Benjie Gillam <benjie@jemjie.com>
|
rebased on main, @graphql/tsc ready for review |
|
Could this be considered editorial only? it clarified existing |
3 participants
add assertions from current behavior of reference implementation