Skip to content

Fix duplicated og:title #1842

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 5, 2024
Merged

Fix duplicated og:title #1842

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 13 additions & 6 deletions src/components/tools-and-libraries.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,16 +168,23 @@ export function CodePage({ allTags, data }: CodePageProps) {

const [sort, setSort] = useState("popularity")

let description = `A collection of tools and libraries for GraphQL`
let title = "Tools and Libraries | GraphQL"
if (selectedTagsAsString) {
description += ` related to ${selectedTagsAsString}`
title = `${selectedTagsAsString} | ${title}`
}

return (
<>
<NextHead>
<title>
{selectedTagsAsString ? selectedTagsAsString + " | " : ""}Tools and
Libraries | GraphQL
</title>
<title>{title}</title>
<meta property="og:title" content={title} key="meta-og-title" />
<meta name="description" content={description} key="meta-description" />
<meta
name="description"
content={`A collection of tools and libraries for GraphQL${selectedTagsAsString ? ` related to ${selectedTagsAsString}` : ""}`}
property="og:description"
content={description}
key="meta-og-description"
/>
</NextHead>
<div className="container py-10 md:py-20">
Expand Down
14 changes: 11 additions & 3 deletions theme.config.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,11 +179,19 @@ export default {
return (
<>
<title>{title}</title>
<meta property="og:title" content={title} />
<meta property="og:title" content={title} key="meta-og-title" />
{description && (
<>
<meta name="description" content={description} />
<meta property="og:description" content={description} />
<meta
name="description"
content={description}
key="meta-description"
/>
<meta
property="og:description"
content={description}
key="meta-og-description"
/>
</>
)}
{canonical && <link rel="canonical" href={canonical} />}
Expand Down
Loading