conference page — missing OG images #2057
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@hasparus is attempting to deploy a commit to the The GraphQL Foundation Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
hasparus
commented
Jul 24, 2025
| size, | ||
| } from "../components/og-images/simple-opengraph-image" | ||
|
|
||
| export default SimpleOpengraphImage.bind(null, { |
There was a problem hiding this comment.
We're using bind here instead of an arrow or a new function because @types/react doesn't seem to know we can return Promise<JSX> just yet.
This should be solved after migrating to React 19, but I'm fine with taking this small stylistic/readability hit just to a void dealing with React versions for now.
hasparus
commented
Jul 24, 2025
| @@ -1,374 +0,0 @@ | |||
| import type { SchedSpeaker } from "@/app/conf/2023/types" | |||
There was a problem hiding this comment.
This file isn't removed, I've moved it to og-images and refactored the smaller components out to new files, so Git didn't catch that.
saihaj
approved these changes
Jul 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I've added the missing OG images for the pages that aren't based on data from Sched.