GraphQLConf 2025 — show event subtype #2082
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@hasparus is attempting to deploy a commit to the The GraphQL Foundation Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
saihaj
reviewed
Aug 16, 2025
Comment on lines
+39
to
+43
| if ( | ||
| session.event_type === "GraphQL in Production" || | ||
| session.event_type === "Developer Experience" || | ||
| session.event_type === "Session Presentations" | ||
| ) { |
There was a problem hiding this comment.
Suggested change
| if ( | |
| session.event_type === "GraphQL in Production" || | |
| session.event_type === "Developer Experience" || | |
| session.event_type === "Session Presentations" | |
| ) { | |
| if (["GraphQL in Production", "Developer Experience", "Session Presentations"].includes(session.event_type)) { |
saihaj
approved these changes
Aug 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We're currently showing GraphQL in Production and Developer Experience in half of the session cards in the schedule grid.
I wrote some cheap and hacky code to show the
event_subtypeinstead but only for these cards, because it may be more informative.WDYT @saihaj?
Disclaimer: This PR includes #2081, but it's just one commit, and I can't stack them from my fork.