GraphQLConf 2025 — allow limited HTML in session descriptions #2097
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@hasparus is attempting to deploy a commit to the The GraphQL Foundation Team on Vercel. A member of the Team first needs to authorize it. |
hasparus
commented
Aug 27, 2025
| session={session} | ||
| className="-mx-px -mb-px last:xl:pb-24" | ||
| /> | ||
| {!!session.speakers?.length && ( |
There was a problem hiding this comment.
The cruise doesn't have speakers.
hasparus
commented
Aug 27, 2025
| <PinIcon className="size-4 text-pri-base [@container(width<240px)]:hidden" /> | ||
| {session.venue} | ||
| </span> | ||
| {session.venue && ( |
There was a problem hiding this comment.
The cruise doesn't have a venue.
hasparus
commented
Aug 27, 2025
| @@ -172,7 +173,7 @@ function AddToCalendarLink({ | |||
| title: eventTitle, | |||
| start: session.event_start, | |||
| end: session.event_end, | |||
| description: session.description, | |||
| description: stripHtml(session.description).result, | |||
There was a problem hiding this comment.
As session.description can have HTML now we need to get rid of it for calendar events.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
saihaj
approved these changes
Aug 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We now render some HTML tags included in session descriptions.