Skip to content

2025 conf pages: Stop downloads on render #2150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 19, 2025
Merged

2025 conf pages: Stop downloads on render #2150

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions src/app/conf/2025/schedule/[id]/page.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,10 +127,12 @@ export default function SessionPage({ params }: SessionProps) {
<ul className="flex max-w-full flex-col gap-y-2">
{session.files?.map(({ path, name }) => (
<li key={path}>
<iframe
src={path}
className="aspect-video size-full"
/>
{path.endsWith(".pdf") && canRenderPdf() ? (
<iframe
src={path}
className="aspect-video size-full"
/>
) : null}
<div className="flex items-stretch justify-between overflow-hidden">
<a
className="typography-link flex items-center truncate p-3 leading-none text-neu-700 max-xs:hidden sm:px-6"
Expand Down Expand Up @@ -295,3 +297,9 @@ function SessionDescription({ session }: { session: ScheduleSession }) {
</div>
)
}

const isFirefox = navigator.userAgent.toLowerCase().includes("firefox")

function canRenderPdf() {
return !isFirefox && !!navigator?.mimeTypes?.["application/pdf" as any]
}