Sync with upstream - v2.4.1

.github/ISSUE_TEMPLATE/bug_report.md

@@ -0,0 +1,51 @@
+---
+name: Bug report
+about: Create a report to help us improve
+title: ''
+labels: ''
+assignees: LudovicRousseau
+
+---
+
+**Describe the bug**
+A clear and concise description of what the bug is.
+
+**To Reproduce**
+Steps to reproduce the behavior:
+1. 
+2. 
+3. 
+4. 
+
+**Expected behavior**
+A clear and concise description of what you expected to happen.
+
+**Versions:**
+- smart card reader driver name and version
+- pcsc-lite version
+- the output of the command `/usr/sbin/pcscd --version`
+
+**Platform:**
+- Operating system or GNU/Linux distribution name and version
+- Smart card middleware name and version
+- Smart card reader manufacturer name and reader model name
+- Smart card name
+
+**Log:**
+Then you shall generate a complete log (do not truncate it).
+
+- If you need to enter the smart card PIN to reproduce the problem then
+  consider changing your PIN before generating the logs as the PIN value
+  will be included in the logs.
+- Kill any running pcscd process
+- (re)start pcscd exactly as described bellow:
+```
+sudo LIBCCID_ifdLogLevel=0x000F pcscd --foreground --debug --apdu --color | tee log.txt
+```
+- Stop pcscd (using Control-C) after the problem occurred and send me the
+  generated `log.txt` file
+
+See also https://pcsclite.apdu.fr/#support
+
+**Additional context**
+Add any other context about the problem here.

.github/workflows/build.yml

@@ -26,7 +26,7 @@ jobs:
     steps:
       # Checks-out your repository under $GITHUB_WORKSPACE, so your job
       # can access it
-      - uses: actions/checkout@v2
+      - uses: actions/checkout@v4
 
       - name: setup prerequisites
         shell: bash
@@ -46,11 +46,11 @@ jobs:
         shell: bash
         run: |
           ./bootstrap
-          export CFLAGS="-Wall -Wextra -Wformat -Wformat-security -Wmissing-declarations -Wmissing-prototypes -Wold-style-definition -Wpointer-arith -Wredundant-decls -Wshadow -Wstrict-prototypes -Wswitch-enum -Wundef -Wuninitialized -Wunused -Wwrite-strings -Wmissing-noreturn -flto=auto -O2 -Wp,-D_FORTIFY_SOURCE=2"
-          ./configure ${{ matrix.configure_args }}
+          export CFLAGS="-Wall -Wextra -Wformat -Wformat-security -Wmissing-declarations -Wmissing-prototypes -Wold-style-definition -Wpointer-arith -Wredundant-decls -Wshadow -Wstrict-prototypes -Wswitch-enum -Wundef -Wuninitialized -Wunused -Wwrite-strings -Wmissing-noreturn -flto=auto -O2"
+          ./configure --disable-polkit ${{ matrix.configure_args }}
           make V=1
 
       - name: distcheck
         shell: bash
         run: |
-          make distcheck
+          AM_DISTCHECK_CONFIGURE_FLAGS=--disable-polkit make distcheck

.github/workflows/build_meson.yml

@@ -0,0 +1,59 @@
+name: build_meson
+
+# Controls when the action will run. Triggers the workflow on push or pull request
+# events but only for the master branch
+on: [push, pull_request]
+
+# A workflow run is made up of one or more jobs that can run
+# sequentially or in parallel
+jobs:
+  # This workflow contains a single job called "build"
+  build:
+    runs-on: ubuntu-latest
+
+    # Steps represent a sequence of tasks that will be executed as part of the job
+    steps:
+      # Checks-out your repository under $GITHUB_WORKSPACE, so your job
+      # can access it
+      - uses: actions/checkout@v4
+
+      - name: setup prerequisites
+        shell: bash
+        run: |
+          sudo apt update
+          sudo apt install \
+            autoconf-archive \
+            debhelper-compat \
+            doxygen \
+            dpkg-dev \
+            flex \
+            libpolkit-gobject-1-dev \
+            libsystemd-dev \
+            libudev-dev \
+            libusb-1.0-0-dev \
+            meson \
+            pkg-config
+
+      - name: compile
+        shell: bash
+        run: |
+          export CFLAGS="-Wall -Wextra -Wformat -Wformat-security -Wmissing-declarations -Wmissing-prototypes -Wold-style-definition -Wpointer-arith -Wredundant-decls -Wshadow -Wstrict-prototypes -Wswitch-enum -Wundef -Wuninitialized -Wunused -Wwrite-strings -Wmissing-noreturn -flto=auto -O2"
+          meson setup builddir --werror
+          cd builddir
+
+          DESTDIR=/tmp/pcsc meson install
+          find /tmp/pcsc
+
+          meson dist
+
+          # doxygen
+          meson compile doc
+
+          meson setup --reconfigure -Dlibsystemd=false -Dlibudev=false -Dpolkit=false
+          meson compile
+
+          meson setup --reconfigure -Dserial=true
+          meson compile
+
+          meson setup --reconfigure -Dembedded=true
+          meson compile