Fix agent working directory to use target path, allowing user to invoke Conclave from a different dir#6
Open
paulkarayan wants to merge 2 commits intogravitational:mainfrom
Open
Conversation
Author
|
PR doesn't actually fix it! will fix... |
Author
|
ok - so what I found was a stale plan caused the same testing to be run! now it works after I also added:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I followed the quickstart and was confused as to why my Conclave runs were showing prompt injection vulns in files in the the ~/conclave directory despite invoking it as such:
./conclave --claude run ~/golang-learning/dj-broadcastI saw that Agent subprocesses (Claude, Codex, Gemini) were not being started in the target codebase directory, and were likely inheriting the working directory of the conclave process itself. The bug only surfaces when invoking Conclave from a different directory with an explicit path argument.
I think what's happening is the [path] argument exists but wasn't wired through to the agent subprocesses. This could have been missed if it was invoked with
go runor a user had it in their GOPATH/bin.Fix
I added
var GlobalWorkDir stringto match how the codebase already uses GlobalSession and GlobalRegistry, then set cmd.Dir on all agent subprocesses.Alternative: update the documentation to specify invocation expections
Testing
conclave --claude run <some-other-project>from the conclave repo directory