Merged
Conversation
vapopov
force-pushed
the
vapopov/add-default-headers-for-client
branch
from
e3f6fdf to
983817c
Compare
hugoShaka
approved these changes
Oct 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR, I added the ability to define default headers for the roundtrip client. Currently, we cannot pass extra headers from the tsh client to the proxy. This change is needed to propagate the tsh client version to the auth service in order to collect metrics about client tool versions. Additionally, during login requests, we want to capture which proxy was used to better understand whether a customer needs support for specific regions.
Related: https://github.com/gravitational/cloud/issues/14225