Fixing container-image Makefile target to use correct build arg name #391
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doggydogworld
changed the title
fheinecke
approved these changes
Aug 8, 2025
doggydogworld
force-pushed
the
gus/fix-container-image-build
branch
from
8b5337b to
370b137
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Dockerfile declares a build arg
TOOL_NAMEthat used to be calledFILE_NAME. The Makefile target was forgotten when this change was made, so when building a container image locally with the target theCOPYstep will use a different path than expected.The CD workflow works as expected, this only affects local development when using the
container-imagetarget.