[v18] use new join service for bot joins#60166
Closed
nklaassen wants to merge 1 commit intonklaassen/v18/join-boundkeypair-testsfrom
Closed
[v18] use new join service for bot joins#60166nklaassen wants to merge 1 commit intonklaassen/v18/join-boundkeypair-testsfrom
nklaassen wants to merge 1 commit intonklaassen/v18/join-boundkeypair-testsfrom
Conversation
Backport #59550 to branch/v18
boxofrad
approved these changes
Oct 13, 2025
strideynet
approved these changes
Oct 13, 2025
Contributor
Author
|
I will backport this in #60293 instead |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport #59550 to branch/v18
I currently plan to hold off on merging this until either the next minor release or if/when a new join method available only in the new join service is required in v18