Merged
Conversation
This adds a new `env0` join method to support joining from env0 workflows, and especially the embedded tbot in the Terraform provider when running on env0. This is the first OIDC join method on the new join service, and will not support legacy joining. As such, it won't be backported beyond v18. Closes #53798 changelog: Add new `env0` join method to support joining within Env0 workflows
This fixes some issues in env0 token validation: - azp check is disabled since it's set to a random (ish) value - Use correct audience URL (their docs specified the wrong value)
timothyb89
force-pushed
the
timothyb89/env0-joining
branch
from
c76ec3a to
f3c2095
Compare
timothyb89
temporarily deployed
to
docs-amplify
GitHub Actions
Inactive
Contributor
|
Amplify deployment status
|
timothyb89
temporarily deployed
to
docs-amplify
GitHub Actions
Inactive
timothyb89
commented
Oct 23, 2025
|
|
||
| // env0Audience is the audience for the token. This is unfortunately hard | ||
| // coded. | ||
| env0Audience = "https://prod.env0.com" |
Contributor
Author
There was a problem hiding this comment.
The example token in their public docs unfortunately specify the wrong value here 🙁 https://docs.envzero.com/guides/integrations/oidc-integrations#format-of-the-openid-connect-id-token
(At least the value in the table is correct, but I'm glad I was able to test it explicitly...)
timothyb89
temporarily deployed
to
docs-amplify
GitHub Actions
Inactive
github-actions
bot
requested review from
bernardjkim,
boxofrad,
hugoShaka,
marcoandredinis,
mmcallister,
ptgott,
r0mant,
strideynet,
tigrato and
zmb3
Specific validation logic is now separate and the validator is passed as an argument to a generic `handleOIDCJoin()` handler.
timothyb89
temporarily deployed
to
docs-amplify
GitHub Actions
Inactive
timothyb89
temporarily deployed
to
docs-amplify
GitHub Actions
Inactive
tigrato
approved these changes
Oct 27, 2025
nklaassen
approved these changes
Oct 27, 2025
timothyb89
temporarily deployed
to
docs-amplify
GitHub Actions
Inactive
zmb3
approved these changes
Oct 27, 2025
timothyb89
temporarily deployed
to
docs-amplify
GitHub Actions
Inactive
Contributor
|
@timothyb89 See the table below for backport results.
|
timothyb89
added a commit
that referenced
this pull request
Oct 29, 2025
* Add Env0 method This adds a new `env0` join method to support joining from env0 workflows, and especially the embedded tbot in the Terraform provider when running on env0. This is the first OIDC join method on the new join service, and will not support legacy joining. As such, it won't be backported beyond v18. Closes #53798 changelog: Add new `env0` join method to support joining within Env0 workflows * Fix imports * Fix failing test * Add env0 token source * Fix missing env0 join method in tbot * Fix env0 validation This fixes some issues in env0 token validation: - azp check is disabled since it's set to a random (ish) value - Use correct audience URL (their docs specified the wrong value) * Fix incorrect date in new file copyright header * Fix generated tfschema * Fix failing test after adding the token source * First round of code review * Add example token claims in comment * Move common OIDC handling logic into a separate handler Specific validation logic is now separate and the validator is passed as an argument to a generic `handleOIDCJoin()` handler. * Fix imports * Rename joinclient/join_env0.go to join_oidc.go
timothyb89
added a commit
that referenced
this pull request
Oct 31, 2025
* Add Env0 method This adds a new `env0` join method to support joining from env0 workflows, and especially the embedded tbot in the Terraform provider when running on env0. This is the first OIDC join method on the new join service, and will not support legacy joining. As such, it won't be backported beyond v18. Closes #53798 changelog: Add new `env0` join method to support joining within Env0 workflows * Fix imports * Fix failing test * Add env0 token source * Fix missing env0 join method in tbot * Fix env0 validation This fixes some issues in env0 token validation: - azp check is disabled since it's set to a random (ish) value - Use correct audience URL (their docs specified the wrong value) * Fix incorrect date in new file copyright header * Fix generated tfschema * Fix failing test after adding the token source * First round of code review * Add example token claims in comment * Move common OIDC handling logic into a separate handler Specific validation logic is now separate and the validator is passed as an argument to a generic `handleOIDCJoin()` handler. * Fix imports * Rename joinclient/join_env0.go to join_oidc.go
timothyb89
added a commit
that referenced
this pull request
Nov 3, 2025
* Add Env0 method This adds a new `env0` join method to support joining from env0 workflows, and especially the embedded tbot in the Terraform provider when running on env0. This is the first OIDC join method on the new join service, and will not support legacy joining. As such, it won't be backported beyond v18. Closes #53798 changelog: Add new `env0` join method to support joining within Env0 workflows * Fix imports * Fix failing test * Add env0 token source * Fix missing env0 join method in tbot * Fix env0 validation This fixes some issues in env0 token validation: - azp check is disabled since it's set to a random (ish) value - Use correct audience URL (their docs specified the wrong value) * Fix incorrect date in new file copyright header * Fix generated tfschema * Fix failing test after adding the token source * First round of code review * Add example token claims in comment * Move common OIDC handling logic into a separate handler Specific validation logic is now separate and the validator is passed as an argument to a generic `handleOIDCJoin()` handler. * Fix imports * Rename joinclient/join_env0.go to join_oidc.go
mmcallister
pushed a commit
that referenced
this pull request
Nov 6, 2025
* Add Env0 method This adds a new `env0` join method to support joining from env0 workflows, and especially the embedded tbot in the Terraform provider when running on env0. This is the first OIDC join method on the new join service, and will not support legacy joining. As such, it won't be backported beyond v18. Closes #53798 changelog: Add new `env0` join method to support joining within Env0 workflows * Fix imports * Fix failing test * Add env0 token source * Fix missing env0 join method in tbot * Fix env0 validation This fixes some issues in env0 token validation: - azp check is disabled since it's set to a random (ish) value - Use correct audience URL (their docs specified the wrong value) * Fix incorrect date in new file copyright header * Fix generated tfschema * Fix failing test after adding the token source * First round of code review * Add example token claims in comment * Move common OIDC handling logic into a separate handler Specific validation logic is now separate and the validator is passed as an argument to a generic `handleOIDCJoin()` handler. * Fix imports * Rename joinclient/join_env0.go to join_oidc.go
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 13, 2025
* Add Env0 method This adds a new `env0` join method to support joining from env0 workflows, and especially the embedded tbot in the Terraform provider when running on env0. This is the first OIDC join method on the new join service, and will not support legacy joining. As such, it won't be backported beyond v18. Closes #53798 changelog: Add new `env0` join method to support joining within Env0 workflows * Fix imports * Fix failing test * Add env0 token source * Fix missing env0 join method in tbot * Fix env0 validation This fixes some issues in env0 token validation: - azp check is disabled since it's set to a random (ish) value - Use correct audience URL (their docs specified the wrong value) * Fix incorrect date in new file copyright header * Fix generated tfschema * Fix failing test after adding the token source * First round of code review * Add example token claims in comment * Move common OIDC handling logic into a separate handler Specific validation logic is now separate and the validator is passed as an argument to a generic `handleOIDCJoin()` handler. * Fix imports * Rename joinclient/join_env0.go to join_oidc.go
mmcallister
pushed a commit
that referenced
this pull request
Nov 19, 2025
* Add Env0 method This adds a new `env0` join method to support joining from env0 workflows, and especially the embedded tbot in the Terraform provider when running on env0. This is the first OIDC join method on the new join service, and will not support legacy joining. As such, it won't be backported beyond v18. Closes #53798 changelog: Add new `env0` join method to support joining within Env0 workflows * Fix imports * Fix failing test * Add env0 token source * Fix missing env0 join method in tbot * Fix env0 validation This fixes some issues in env0 token validation: - azp check is disabled since it's set to a random (ish) value - Use correct audience URL (their docs specified the wrong value) * Fix incorrect date in new file copyright header * Fix generated tfschema * Fix failing test after adding the token source * First round of code review * Add example token claims in comment * Move common OIDC handling logic into a separate handler Specific validation logic is now separate and the validator is passed as an argument to a generic `handleOIDCJoin()` handler. * Fix imports * Rename joinclient/join_env0.go to join_oidc.go
mmcallister
pushed a commit
that referenced
this pull request
Nov 20, 2025
* Add Env0 method This adds a new `env0` join method to support joining from env0 workflows, and especially the embedded tbot in the Terraform provider when running on env0. This is the first OIDC join method on the new join service, and will not support legacy joining. As such, it won't be backported beyond v18. Closes #53798 changelog: Add new `env0` join method to support joining within Env0 workflows * Fix imports * Fix failing test * Add env0 token source * Fix missing env0 join method in tbot * Fix env0 validation This fixes some issues in env0 token validation: - azp check is disabled since it's set to a random (ish) value - Use correct audience URL (their docs specified the wrong value) * Fix incorrect date in new file copyright header * Fix generated tfschema * Fix failing test after adding the token source * First round of code review * Add example token claims in comment * Move common OIDC handling logic into a separate handler Specific validation logic is now separate and the validator is passed as an argument to a generic `handleOIDCJoin()` handler. * Fix imports * Rename joinclient/join_env0.go to join_oidc.go
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a new
env0join method to support joining from env0 workflows, and especially the embedded tbot in the Terraform provider when running on env0.This is the first OIDC join method on the new join service, and includes new messages that will be shared among all OIDC join methods. Unlike legacy OIDC join methods which will be ported to the new join service, this new join method will not support legacy joining and won't be backported beyond v18.
Closes #53798
changelog: Add new
env0join method to support joining within Env0 workflows