[v18] Add proto definitions for the Sub CA feature#63973
Open
codingllama wants to merge 2 commits intobranch/v18from
Open
[v18] Add proto definitions for the Sub CA feature#63973codingllama wants to merge 2 commits intobranch/v18from
codingllama wants to merge 2 commits intobranch/v18from
Conversation
* Add proto definitions for the Sub CA feature * Add license * Document print format of PublicKeyHash * Simplify comment on ATV.value * Document CreateCSR behavior on HSMs * Use an optional value for ATV * List doesn't take an ID * Print public key hashes in hex * Mention that each Auth signs all its keys in CreateCSR * Add Create and Update RPCs * Fix typos and Get/List responses
1ad60ab to
f43fd20
Compare
Contributor
Author
|
Squashed commits so it's a bit cleaner and ran |
Contributor
|
New features should be backported as a whole, and it's actively harmful to solely backport protobuf codegen IMO - until those are in a release branch we can break compat if need be, but once they're released they're there to stay. |
codingllama
commented
Feb 19, 2026
espadolini
approved these changes
Feb 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport #63737 to branch/v18
https://github.com/gravitational/teleport.e/issues/7675