[v18] Fixes possible collisions when hashing immutable labels#63981
Merged
eriktate merged 1 commit intobranch/v18from Feb 20, 2026
Merged
[v18] Fixes possible collisions when hashing immutable labels#63981eriktate merged 1 commit intobranch/v18from
eriktate merged 1 commit intobranch/v18from
Conversation
fspmarshall
approved these changes
Feb 19, 2026
nklaassen
approved these changes
Feb 19, 2026
6b2395c to
ecb393b
Compare
* fixing possibility of collisions when hashing immutable labels * reworking to also handle collisions between service types and single label collisions * adding known-good hash regression tests * adding fuzz test
ecb393b to
416ed37
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backports #63733 to branch/v18
Manual testing
tctl scoped tokens add --type=node --scope=/local --assign-scope=/local --ssh-labels=aaa=bbbcccddd{ "immutable_labels": { "ssh": { "aaa": "bbb", "ccc": "ddd" } } }