EC2 auto-discovery: emit IAM permission errors as UserTasks#64004
Draft
EC2 auto-discovery: emit IAM permission errors as UserTasks#64004
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #62828
Changelog: Added UserTask alerts when EC2 auto-discovery fails due to missing IAM permissions (
ec2:DescribeInstances,account:ListRegions, or Organizations APIs), enabling users to identify and resolve permission issues through the Web UI.Test cases
dtctl get nodes --format=json | jq '.[]'dtctl get user_tasks --format=json | jq '.[] | select(.spec.issue_type | startswith("ec2-perm"))'returns emptyec2-perm-account-deniedUserTaskec2:DescribeInstancesto the integration roleissue_type=ec2-perm-account-deniedand region populatedIAM permission error during EC2 discoverywarning with correct context fieldsec2-perm-account-deniedUserTaskaccount:ListRegionsto the integration roleregions = ["*"]issue_type=ec2-perm-account-deniedand empty region fieldec2-perm-org-deniedUserTask (manual -- no Terraform for org matcher)dtctl createorganizations:ListRoots,organizations:ListChildren,organizations:ListAccountsForParentissue_type=ec2-perm-org-deniedand empty regionec2:DescribeInstancesin a DIFFERENT region (not the one your instances are in)