Skip to content

Remove github.com/google/shlex dependency 🧹 💨 #64059

Open
cthach wants to merge 1 commit intomasterfrom
cthach/remove-shlex-dep
Open

Remove github.com/google/shlex dependency 🧹 💨 #64059
cthach wants to merge 1 commit intomasterfrom
cthach/remove-shlex-dep

Conversation

@cthach
Copy link
Contributor

@cthach cthach commented Feb 24, 2026

The github.com/google/shlex module was archived on Dec 29, 2022. It is only used once. The github.com/mattn/go-shellwords module is a drop-in replacement and we already import it.

Sent from an ✈️

Manual Test Plan

Test Environment

Used the following tsh config at ~/.tsh/config/config.yaml:

aliases:
  "l": "tsh login --proxy=teleport.dev:443 --user=teleport-admin"

Test Cases

List the various tests that were run to validate the change. Cases should be as exhaustive as possible.

  • Running ./build/tsh l should resolve the alias.

Signed-off-by: Chris Thach <chris.thach@goteleport.com>
@cthach cthach self-assigned this Feb 24, 2026
@cthach cthach added go Issues related to Go builds/tooling dependencies Pull requests that update a dependency file backport/branch/v17 backport/branch/v18 labels Feb 24, 2026
@cthach cthach changed the title WIP: Remove github.com/google/shlex dependency 🧹 💨 Remove github.com/google/shlex dependency 🧹 💨 Feb 25, 2026
@cthach cthach marked this pull request as ready for review February 25, 2026 02:05
@github-actions github-actions bot added size/sm tsh tsh - Teleport's command line tool for logging into nodes running Teleport. labels Feb 25, 2026
@cthach cthach requested review from Joerger, nklaassen and williamong-tel and removed request for Joerger, camscale and ravicious February 25, 2026 02:22
@cthach cthach added the no-changelog Indicates that a PR does not require a changelog entry label Feb 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport/branch/v17 backport/branch/v18 dependencies Pull requests that update a dependency file go Issues related to Go builds/tooling no-changelog Indicates that a PR does not require a changelog entry size/sm tsh tsh - Teleport's command line tool for logging into nodes running Teleport.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant