[v18] Deflake TestListResources_WithLogins#64086
Open
zmb3 wants to merge 2 commits intobranch/v18from
Open
Conversation
The main fix is to wait for the items we've inserted to show up in the unified resources cache. In addition, we make sure the test won't loop forever by breaking out of the loop if we know we've hit the last page, and relaxing the loop condition so that we terminate as soon as we get at least 5 resources instead of exactly 5 resources. Closes #62426
Co-authored-by: rosstimothy <39066650+rosstimothy@users.noreply.github.com>
zmb3
added
the
no-changelog
rosstimothy
approved these changes
Feb 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport #64056 to branch/v18