Skip to content

Deflake TestIntegrations/DifferentPinnedIP#64089

Open
zmb3 wants to merge 1 commit intomasterfrom
zmb3/test-pinned-ip
Open

Deflake TestIntegrations/DifferentPinnedIP#64089
zmb3 wants to merge 1 commit intomasterfrom
zmb3/test-pinned-ip

Conversation

@zmb3
Copy link
Collaborator

@zmb3 zmb3 commented Feb 25, 2026

Wait for the node to be regsitered before attempting to dial it.

Closes #55697

Wait for the node to be regsitered before attempting to dial it.

Closes #55697
@zmb3 zmb3 added no-changelog Indicates that a PR does not require a changelog entry backport/branch/v17 backport/branch/v18 labels Feb 25, 2026
@zmb3 zmb3 requested a review from rosstimothy February 25, 2026 18:26
site := teleInstance.GetSiteAPI(helpers.Site)
require.NotNil(t, site)

require.NoError(t, teleInstance.WaitForNodeCount(t.Context(), helpers.Site, 1))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should already be automatically happening in the Start call on line 234 above.

// Wait for any SSH instances to be visible in the inventory before returning
// to prevent any immediate connection attempts from failing because the host
// has not yet been propagated to the caches.
expectedNodes := len(i.Nodes)
if i.Config.SSH.Enabled {
expectedNodes++
}
if err := i.WaitForNodeCount(context.Background(), i.Secrets.SiteName, expectedNodes); err != nil {
return trace.Wrap(err)
}

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, you know I was thinking that would be good default behavior.

Copy link
Contributor

@rosstimothy rosstimothy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not certain this will truly resolve the flake. I think there is a more systemic issue that is plaguing this and other tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport/branch/v17 backport/branch/v18 no-changelog Indicates that a PR does not require a changelog entry size/sm

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TestIntegrations/DifferentPinnedIP flakiness

2 participants