Open
Conversation
Wait for the node to be regsitered before attempting to dial it. Closes #55697
rosstimothy
reviewed
Feb 25, 2026
| site := teleInstance.GetSiteAPI(helpers.Site) | ||
| require.NotNil(t, site) | ||
|
|
||
| require.NoError(t, teleInstance.WaitForNodeCount(t.Context(), helpers.Site, 1)) |
Contributor
There was a problem hiding this comment.
This should already be automatically happening in the Start call on line 234 above.
teleport/integration/helpers/instance.go
Lines 1395 to 1405 in 3697eac
Collaborator
Author
There was a problem hiding this comment.
Ah, you know I was thinking that would be good default behavior.
rosstimothy
reviewed
Feb 25, 2026
Contributor
rosstimothy
left a comment
There was a problem hiding this comment.
I'm not certain this will truly resolve the flake. I think there is a more systemic issue that is plaguing this and other tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wait for the node to be regsitered before attempting to dial it.
Closes #55697