add testing instructions for k8s operator integration#64388
add testing instructions for k8s operator integration#64388williamong-tel wants to merge 3 commits intomasterfrom
Conversation
williamong-tel
added
the
no-changelog
|
On a side note, running make image in our root repo takes a million years, do you guys have any suggestions for devs in order to speed things up? |
bernardjkim
left a comment
bernardjkim
left a comment
There was a problem hiding this comment.
Thanks for taking the time to add testing documentation!
|
|
||
| ```shell | ||
| # From the repo root | ||
| make image |
There was a problem hiding this comment.
Does this make target still work as intended? I'm unable to use this to build an image.
You might be able to take a look at deploy-cloud.sh and dev-deploy.md in the private repo for some inspiration. I usually use that script to build local images and deploy to my cloud staging cluster for testing.
There was a problem hiding this comment.
Do you remember what errors you were getting? I had errors also, but after running make -C build.assets buildbox-centos7, I was able to proceed.
There was a problem hiding this comment.
I rebuilt an image and I did have some issues.
I've updated the troubleshooting part and hopefully you can run it this time https://github.com/gravitational/teleport/pull/64388/changes#diff-2a7b69b8f52f3c8407e31436f330f5395b0873ee267be8d9da6861d89778eaecR117
It does take forever to run make image though :(
Updated troubleshooting instructions for local image build in CONTRIBUTING.md.
3 participants
I previously didn't realize we had a make k3d-deploy target. Updated the makefile and contributing.md so that new devs are more aware and I think this will help speed up testing.
Changes:
Update the CONTRIBUTING.md to include a testing section that utilizes k3d.
Update the make target to help easier run locally built images.