[buddy] Update URI creation for Roles Anywhere integration in govcloud#64516
Open
marcoandredinis wants to merge 3 commits intomasterfrom
Open
[buddy] Update URI creation for Roles Anywhere integration in govcloud#64516marcoandredinis wants to merge 3 commits intomasterfrom
marcoandredinis wants to merge 3 commits intomasterfrom
Conversation
Noticed that RA defaults to a commercial URI which will not successfully launch a console in govcloud. This change updates the URI creation logic to use the correct URI when the parsed ARNs indicate a govcloud partition.
marcoandredinis
added
the
no-changelog
marcoandredinis
added
backport/branch/v18
and removed
no-changelog
Contributor
Author
|
@bmckenna805 Thank you again for your contribution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog: Fixed AWS IAM Roles Anywhere Web/Console access for Gov Cloud and China partitioned AWS accounts.
The UI guide has a hard check for
arn:aws:prefix when creating the integration (after running the shell script), so in order to test this, users have to onboard the integration using the docs guide.Manual Test Plan
Test Environment
Tested locally
Test Cases