[v17] Fix Desktop Connection Error When HostID Is Not a UUID (#63908)#64546
[v17] Fix Desktop Connection Error When HostID Is Not a UUID (#63908)#64546rhammonds-teleport wants to merge 2 commits intobranch/v17from
Conversation
* Fix windows desktop connection error when the configured HostID is not a UUID. * Rename 'hostID' to 'rdpClientID'
rhammonds-teleport
force-pushed
the
rhammonds/backport-63908-branch/v17
branch
from
7a21677 to
103237d
Compare
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 103237d7b6
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
|
||
| // Fall back to taking a hash of the rdpClientID | ||
| hash := [16]byte{} | ||
| copy(hash[:], md5.New().Sum([]byte(id))) |
There was a problem hiding this comment.
For non-UUID HostID values, md5.New().Sum([]byte(id)) does not compute md5(id); Hash.Sum appends the current digest to the provided slice, so this returns id || md5(""). Because the next line copies only 16 bytes, any non-empty IDs are effectively truncated/prefixed rather than hashed, which can cause client ID collisions (for example IDs sharing the same first 16 bytes) and undermines the fallback uniqueness this change is meant to preserve.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
This is correct. I misunderstood the Hash interface. I've updated both backports and will need to get this change into master as well.
Side note: It would be nice to have the codex run its review in the draft stage so that we can find and fix things before pinging reviewers.
1 participant
Backports #63908
Changelog: Fixed bug that causes Windows desktop connection errors on EC2 joined nodes.
Manual Test Plan
Test Environment
Test Cases