[v18] Disable http_proxy for IMDS/metadata services#64552
[v18] Disable http_proxy for IMDS/metadata services#64552marcoandredinis wants to merge 2 commits intobranch/v18from
Conversation
marcoandredinis
force-pushed
the
bot/backport-64158-branch/v18
branch
from
d346c6e to
fe7f34d
Compare
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: fe7f34df65
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| loggerWithVMMetadata.ErrorContext(ctx, "Installing teleport in GCP VM failed", | ||
| "ip", ip, | ||
| "error", err, |
There was a problem hiding this comment.
This ErrorContext call now runs on every failed SSH attempt, even when a later IP succeeds and the function returns nil. On multi-homed instances (for example, first IP unreachable, second reachable), this produces misleading "Installing teleport in GCP VM failed" error logs for successful installs, which can trigger false alarms and obscure real failures. The error-level log should be restricted to terminal failure paths.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
I can move this to a warning. But I'll create another PR for it.
1 participant
Backport #64158 to branch/v18
changelog: Fixed Azure and GCP server auto-discovery installation when the target VM had a system-wide HTTP proxy configured.
Manual Test Plan
Test Environment
local cluster
Test Cases