Remove use of github.com/lib/pq as direct dependency#64584
Draft
adamkpickering wants to merge 1 commit intomasterfrom
Draft
Remove use of github.com/lib/pq as direct dependency#64584adamkpickering wants to merge 1 commit intomasterfrom
github.com/lib/pq as direct dependency#64584adamkpickering wants to merge 1 commit intomasterfrom
Conversation
rosstimothy
reviewed
Mar 12, 2026
go.mod
Outdated
| github.com/julienschmidt/httprouter v1.3.0 // replaced | ||
| github.com/keys-pub/go-libfido2 v1.5.3-0.20220306005615-8ab03fb1ec27 // replaced | ||
| github.com/lib/pq v1.10.9 | ||
| github.com/lib/pq v1.10.9 // indirect |
Contributor
There was a problem hiding this comment.
Can you please move this to the indirect dependencies block below?
Contributor
Author
There was a problem hiding this comment.
That's funny, I guess go mod tidy doesn't do that. Done.
adamkpickering
force-pushed
the
adamkpickering/remove-lib-pq-dep
branch
from
4b6fdfc to
8383a10
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As @rosstimothy noticed, we use
github.com/lib/pqin only one place. This PR replaces that use with a type fromgithub.com/jackc/pgconn.Changelog: Remove direct dependency on github.com/lib/pq.
Manual Test Plan
Test Environment
Test Cases
db_permissionsset, and keep that session alive.db_permissionson the role so that the set of permissions granted to the user is different.db_permissionsset, and keep that session alive.db_permissions, attempt to start a second simultaneous session with the same user.