[v18] kube: validate impersonation principals against RFC 2616#64586
Open
tigrato wants to merge 1 commit intobranch/v18from
Open
[v18] kube: validate impersonation principals against RFC 2616#64586tigrato wants to merge 1 commit intobranch/v18from
tigrato wants to merge 1 commit intobranch/v18from
Conversation
* kube: validate impersonation principals against RFC 2616 Validate the kubernetes impersonation user and group values computed in computeImpersonatedPrincipals using httpguts.ValidHeaderFieldValue before they are forwarded as HTTP headers. This rejects values containing CRLF sequences or null bytes that could otherwise be used for header injection attacks via crafted role definitions. Signed-off-by: Tiago Silva <tiago.silva@goteleport.com> * handle julia's feedback --------- Signed-off-by: Tiago Silva <tiago.silva@goteleport.com>
juliaogris
approved these changes
Mar 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #64488 to branch/v18
Changelog: Validate Kubernetes impersonation user and group header values to prevent CRLF or null-byte header injection via crafted role definitions