Remove OpenSSL FIPS configuration from the FIPS build image#64591
Open
Remove OpenSSL FIPS configuration from the FIPS build image#64591
Conversation
PR #34950 put OpenSSL into FIPS mode in the _build container_, which causes any build tooling that relies on OpenSSL to use FIPS crypto. A result of that change is that we can no longer update our Rust toolchain. The `cargo` utility shipped with Rust versions newer than 1.86 depends on a newer version of OpenSSL, and when this version runs in FIPS mode cargo itself is not able to fetch dependencies from the public registry due to incompatible cipher suites. Note: our build artifacts are still compiled against FIPS-validated modules (Go's GOEXPERIMENT=boring, and Cloudflare's boring crate for Rust).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #34950 put OpenSSL into FIPS mode in the build container, which causes any build tooling that relies on OpenSSL to use FIPS crypto.
A result of that change is that we can no longer update our Rust toolchain. The
cargoutility shipped with Rust versions newer than 1.86 depends on a newer version of OpenSSL, and when this version runs in FIPS mode cargo itself is not able to fetch dependencies from the public registry due to incompatible cipher suites.Note: our build artifacts are still compiled against FIPS-validated modules (Go's GOEXPERIMENT=boring, and Cloudflare's boring crate for Rust).
Manual Test Plan
Test Environment
Test Cases