Williamo/v18 fix operator map generation#64597
Williamo/v18 fix operator map generation#64597williamong-tel wants to merge 2 commits intobranch/v18from
Conversation
* fix mapping gen make crd Update schemagen.go update format fix docs update map key fix fix formatting fix formatting Update format.go Update format.go * Update resources-teleport-dev-accesslists.mdx * add back nullable fix nullable * Add schema test Update schema_test.go Update schema_test.go
ran make crd and go mod tidy
|
Amplify deployment status
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: dc28ecda39
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| require.NotEmpty(t, crd.Spec.Versions) | ||
| ver := crd.Spec.Versions[0] | ||
| require.NotNil(t, ver.Schema) |
There was a problem hiding this comment.
Build validators for every CRD version
buildValidators only registers crd.Spec.Versions[0], but this repo contains multi-version CRDs (for example resources.teleport.dev_roles.yaml has several entries under spec.versions), so fixtures targeting any non-first version will not be validated at all (require.NotNil fails) or can be checked against the wrong schema if version ordering changes. This makes the new test miss real schema regressions for versioned resources even though it claims to validate fixtures against CRDs.
Useful? React with 👍 / 👎.
backport of #64459
Had conflicts in the docs and the go.mod and go.sum.
Ran go mod tidy and make crd
Changelog: fix map generation for teleport resources to k8s
Manual Test Plan
Test Environment
Local k3s environment
Test Cases