Skip to content

Commit 1248784

Browse files
committed
Fix typo
1 parent 88e5b6c commit 1248784

File tree

3 files changed

+19
-9
lines changed

3 files changed

+19
-9
lines changed

math.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,12 +23,12 @@ func ToDegrees(radians float64) float64 {
2323
return radians * RadToDeg
2424
}
2525

26-
// Multiple multiple number by scale factor
26+
// Multiply multiplies a number by a scale factor
2727
func Multiple[T Number](a T, factor float64) T {
2828
return Cast[T](float64(a) * factor)
2929
}
3030

31-
// Divide divide number by scale factor
31+
// Divide divides a number by a scale factor; if scale is zero, returns the original value
3232
func Divide[T Number](a T, scale float64) T {
3333
if scale == 0 {
3434
return a

rectangle.go

Lines changed: 15 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ func RectangleFromMinMax[T Number](min, max Point[T]) Rectangle[T] {
2525

2626
// RectangleFromSize creates a Rectangle from zero point and size.
2727
func RectangleFromSize[T Number](size Size[T]) Rectangle[T] {
28-
return Rectangle[T]{P[T](0, 0), size}
28+
return RectangleFromMin(P[T](0, 0), size)
2929
}
3030

3131
// Translate creates a new Rectangle translated by the given vector.
@@ -38,7 +38,7 @@ func (r Rectangle[T]) MoveTo(point Point[T]) Rectangle[T] {
3838
return Rectangle[T]{point, r.Size}
3939
}
4040

41-
// Multiple creates a new Rectangle with size uniformly scaled by the factor.
41+
// Scale creates a new Rectangle with size uniformly scaled by the factor.
4242
func (r Rectangle[T]) Scale(factor float64) Rectangle[T] {
4343
return Rectangle[T]{r.Center, r.Size.Scale(factor)}
4444
}
@@ -68,7 +68,7 @@ func (r Rectangle[T]) Shrink(amount T) Rectangle[T] {
6868
return Rectangle[T]{r.Center, r.Size.Shrink(amount)}
6969
}
7070

71-
// Shrink creates a new Rectangle with size reduced by the given amounts along X and Y.
71+
// ShrinkXY creates a new Rectangle with size reduced by the given amounts along X and Y.
7272
func (r Rectangle[T]) ShrinkXY(amountX, amountY T) Rectangle[T] {
7373
return Rectangle[T]{r.Center, r.Size.ShrinkXY(amountX, amountY)}
7474
}
@@ -117,9 +117,19 @@ func (r Rectangle[T]) TopRight() Point[T] {
117117
return r.Max()
118118
}
119119

120-
// Edges returns the rectangle edges as lines.
120+
// Edges returns the rectangle edges as lines in clockwise order starting from BottomLeft.
121121
func (r Rectangle[T]) Edges() []Line[T] {
122-
return []Line[T]{}
122+
bl := r.BottomLeft()
123+
br := r.BottomRight()
124+
tr := r.TopRight()
125+
tl := r.TopLeft()
126+
127+
return []Line[T]{
128+
L(bl, br),
129+
L(br, tr),
130+
L(tr, tl),
131+
L(tl, bl),
132+
}
123133
}
124134

125135
// Vertices returns the polygon vertices in order starting Min point, counter-clockwise.

regular_polygon.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,12 +27,12 @@ func (rp RegularPolygon[T]) MoveTo(point Point[T]) RegularPolygon[T] {
2727
return RegularPolygon[T]{point, rp.Size, rp.N, rp.Angle}
2828
}
2929

30-
// Multiple creates a new RegularPolygon with size scaled by the given factor.
30+
// Scale creates a new RegularPolygon with size scaled by the given factor.
3131
func (rp RegularPolygon[T]) Scale(factor float64) RegularPolygon[T] {
3232
return RegularPolygon[T]{rp.Center, rp.Size.Scale(factor), rp.N, rp.Angle}
3333
}
3434

35-
// Multiple creates a new RegularPolygon with size scaled by the given factors.
35+
// ScaleXY creates a new RegularPolygon with size scaled by the given factors.
3636
func (rp RegularPolygon[T]) ScaleXY(factorX, factorY float64) RegularPolygon[T] {
3737
return RegularPolygon[T]{rp.Center, rp.Size.ScaleXY(factorX, factorY), rp.N, rp.Angle}
3838
}

0 commit comments

Comments
 (0)