Skip to content

feat: adopt calendar to mobile version #216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

MefistAldemisov
Copy link

Slightly tunned the design of the component:

  1. Added outlined button type for xl sizes, because there is no focus in mobile version
  2. Capitalized the months' names
  3. Set padding between arrows to 8px
  4. Make horizontal and vertical paddings of calendar different and customizable

@gravity-ui-bot
Copy link
Contributor

Preview is ready.

Copy link
Contributor

@korvin89 korvin89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Btw, there is no way (for now) to see this changes in all of our components (except Calendar in pure view) because we use native date pickers in case of mobile view (useMobile hook output)

@@ -45,6 +45,8 @@ export const CalendarView = React.forwardRef<CalendarInstance, CalendarViewProps
state,
);

const buttonView = props.size === 'xl' ? 'outlined' : 'flat';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why we should change button view according to the size property? I suggest u to use useMobile hook here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants