Skip to content

fix(utils): imporve nullish-checking for number inputs #327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
arteria32 merged 3 commits into from
Oct 23, 2025
Merged

fix(utils): imporve nullish-checking for number inputs #327

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8a364f6
fix(utils): improve handling of default values and number conversion …
Oct 10, 2025
e483bd3
fix(utils): refine default value checks in getFieldInitials function
Oct 10, 2025
fdfcad9
fix(utils): simplify default value condition in getFieldInitials func…
Oct 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/lib/core/components/Form/Controller/utils.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -239,7 +239,7 @@ export const getFieldInitials = <
}

if (isNil(value)) {
if (spec.defaultValue) {
if (!(isNil(spec.defaultValue) || spec.defaultValue === '')) {
Copy link
Collaborator

@bocembocem bocembocem Oct 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In what cases do you add a check for an empty string?

Copy link
Contributor Author

@arteria32 arteria32 Oct 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried to minimally change current behavior. And, as it seems to me, in most cases it's empty string = undefined.

value = transformArrIn(spec.defaultValue) as DirtyValue;
}
// if the spec with type array or object, and this spec has "required === true",
Expand Down Expand Up @@ -298,7 +298,7 @@ export const getFieldMethods = <
let value = transformArrIn(_value);

if (isNumberSpec(spec) && !error) {
value = (value ? Number(value) : undefined) as DirtyValue;
value = (isNil(value) || value === '' ? undefined : Number(value)) as DirtyValue;
}

let newChildErrors: Record<string, ValidateError> = {...state.childErrors};
Expand Down