refactor(CodeBlock): store lowlight instance in separate plugin state#1033
Merged
refactor(CodeBlock): store lowlight instance in separate plugin state#1033
Conversation
|
|
|
|
d3m1d0v
changed the title
d3m1d0v
force-pushed
the
codeblock-langs-refactor
branch
from
3bbc356 to
99e2958
Compare
makhnatkin
approved these changes
Mar 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
selectItems/mappingandlowlightinstance from closure-scoped variables inCodeBlockHighlightinto a dedicatedcodeBlockLangsPluginwith proper ProseMirror state managementselectItems→langItems,mapping→aliasMappingTooltipPluginnow reads lang data from editor state viagetCodeBlockLangsState()instead of receiving it through closure parameters