fix(link): fixed link cursor focus #648
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Preview is ready. |
makhnatkin
reviewed
Feb 21, 2025
src/extensions/markdown/Link/plugins/LinkTooltipPlugin/index.tsx
Outdated
Show resolved
Hide resolved
makhnatkin
reviewed
Feb 25, 2025
Contributor
|
Visual Tests Report is ready. |
makhnatkin
approved these changes
Mar 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I solved a problem where if we used a link to the selected text, the focus would be on the penultimate character. The problem was that the link wraps the selected text in [text] and adds one character before. It turns out that the focus that was already there remains in place, but an invisible additional character appears in the text. I solved the problem by adding an empty text selection. However, it was not possible to attach it to the existing dispatch — the link was copied to the plain text. When creating a new dispatch, the problem was solved. If you can tell me how to get around this, I would fix the re-dispatch.