-
Notifications
You must be signed in to change notification settings - Fork 31
feat(quoteLink): add quote link additional plugin #667
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Preview is ready. |
|
makhnatkin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please test the input rule
8fe64ad to
c1b96c3
Compare
81b7420 to
24136b6
Compare
|
During testing, I discovered a couple of bugs that need to be fixed, see the video. cant-delete.movdelete-artefact.mov |
8cb5551 to
36030a8
Compare
|
Visual Tests Report is ready. |
Thank you! I fixed it |
947c959 to
92f65c3
Compare
src/extensions/additional/QuoteLink/QuoteLinkSpecs/md/moveLinkToQuoteAttributes.ts
Outdated
Show resolved
Hide resolved
src/extensions/additional/QuoteLink/QuoteLinkSpecs/md/moveLinkToQuoteAttributes.ts
Outdated
Show resolved
Hide resolved
src/extensions/additional/QuoteLink/PlaceholderWidget/descriptor.tsx
Outdated
Show resolved
Hide resolved
59af465 to
46fbbf4
Compare
c7e78f6 to
ab7d405
Compare
d3m1d0v
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great! 🔥
Added the quote link yfm extension https://preview.gravity-ui.com/md-editor/667/?path=/story/extensions-yfm-quotelink--story
The functionality for editing works with restrictions, without a button (I've left it for improvements so far), you can click on the upper-left corner