feat(quoteLink): add quote link additional plugin#667
Merged
Conversation
Contributor
|
Preview is ready. |
Collaborator
|
makhnatkin
reviewed
Mar 5, 2025
Collaborator
makhnatkin
left a comment
makhnatkin
left a comment
There was a problem hiding this comment.
Please test the input rule
kseniya57
force-pushed
the
quote-link
branch
2 times, most recently
from
8fe64ad to
c1b96c3
Compare
kseniya57
force-pushed
the
quote-link
branch
2 times, most recently
from
81b7420 to
24136b6
Compare
makhnatkin
reviewed
Mar 7, 2025
Collaborator
|
During testing, I discovered a couple of bugs that need to be fixed, see the video. cant-delete.movdelete-artefact.mov |
kseniya57
force-pushed
the
quote-link
branch
2 times, most recently
from
8cb5551 to
36030a8
Compare
Contributor
|
Visual Tests Report is ready. |
Contributor
Author
Thank you! I fixed it |
d3m1d0v
reviewed
Mar 19, 2025
kseniya57
force-pushed
the
quote-link
branch
2 times, most recently
from
947c959 to
92f65c3
Compare
d3m1d0v
reviewed
Mar 24, 2025
src/extensions/additional/QuoteLink/QuoteLinkSpecs/md/moveLinkToQuoteAttributes.ts
Outdated
Show resolved
Hide resolved
src/extensions/additional/QuoteLink/QuoteLinkSpecs/md/moveLinkToQuoteAttributes.ts
Outdated
Show resolved
Hide resolved
d3m1d0v
reviewed
Mar 24, 2025
d3m1d0v
reviewed
Mar 24, 2025
d3m1d0v
reviewed
Mar 24, 2025
d3m1d0v
reviewed
Mar 24, 2025
src/extensions/additional/QuoteLink/PlaceholderWidget/descriptor.tsx
Outdated
Show resolved
Hide resolved
kseniya57
force-pushed
the
quote-link
branch
4 times, most recently
from
59af465 to
46fbbf4
Compare
kseniya57
force-pushed
the
quote-link
branch
3 times, most recently
from
c7e78f6 to
ab7d405
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added the quote link yfm extension https://preview.gravity-ui.com/md-editor/667/?path=/story/extensions-yfm-quotelink--story
The functionality for editing works with restrictions, without a button (I've left it for improvements so far), you can click on the upper-left corner