Skip to content

Conversation

@kseniya57
Copy link
Contributor

@kseniya57 kseniya57 commented Mar 5, 2025

Added the quote link yfm extension https://preview.gravity-ui.com/md-editor/667/?path=/story/extensions-yfm-quotelink--story

The functionality for editing works with restrictions, without a button (I've left it for improvements so far), you can click on the upper-left corner

Screenshot 2025-03-05 at 10 16 01

@kseniya57 kseniya57 self-assigned this Mar 5, 2025
@gravity-ui-bot
Copy link
Contributor

Preview is ready.

@makhnatkin
Copy link
Collaborator

  1. Please look at why the cyclic dependencies have increased and try to change the code so that the number of these dependencies does not increase
  2. When clicking on the quote button, a number of problems arise - the cursor is missing, the first line flickers, the pointer cursor is reflected. Please fix these problems, or add explanatory comments to the story about why the case with flow by clicking on the quote button will not be in a real project

Copy link
Collaborator

@makhnatkin makhnatkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please test the input rule

@kseniya57 kseniya57 force-pushed the quote-link branch 2 times, most recently from 8fe64ad to c1b96c3 Compare March 5, 2025 14:11
@kseniya57 kseniya57 requested a review from makhnatkin March 5, 2025 14:17
@kseniya57 kseniya57 force-pushed the quote-link branch 2 times, most recently from 81b7420 to 24136b6 Compare March 6, 2025 08:43
@makhnatkin
Copy link
Collaborator

During testing, I discovered a couple of bugs that need to be fixed, see the video.

cant-delete.mov
delete-artefact.mov

@kseniya57 kseniya57 force-pushed the quote-link branch 2 times, most recently from 8cb5551 to 36030a8 Compare March 17, 2025 18:25
@gravity-ui-bot
Copy link
Contributor

Visual Tests Report is ready.

@kseniya57
Copy link
Contributor Author

During testing, I discovered a couple of bugs that need to be fixed, see the video.

cant-delete.mov
delete-artefact.mov

Thank you! I fixed it

@kseniya57 kseniya57 force-pushed the quote-link branch 2 times, most recently from 947c959 to 92f65c3 Compare March 24, 2025 06:13
@kseniya57 kseniya57 requested a review from d3m1d0v March 24, 2025 06:17
@kseniya57 kseniya57 force-pushed the quote-link branch 4 times, most recently from 59af465 to 46fbbf4 Compare March 24, 2025 15:27
@kseniya57 kseniya57 requested a review from d3m1d0v March 24, 2025 15:29
@kseniya57 kseniya57 force-pushed the quote-link branch 3 times, most recently from c7e78f6 to ab7d405 Compare March 25, 2025 09:43
Copy link
Member

@d3m1d0v d3m1d0v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! 🔥

@d3m1d0v d3m1d0v merged commit 138120a into main Mar 25, 2025
5 checks passed
@d3m1d0v d3m1d0v deleted the quote-link branch March 25, 2025 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants