fix(YfmTable): fixed positioning of floating controls when scrolling horizontally in table #887
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Preview is ready. |
Contributor
|
Visual Tests Report is ready. |
d3m1d0v
force-pushed
the
fix-yfm-table-floating
branch
2 times, most recently
from
7bf4b75 to
40e4d76
Compare
…scrolled horizontally
d3m1d0v
force-pushed
the
fix-yfm-table-floating
branch
from
40e4d76 to
68c55e2
Compare
d3m1d0v
force-pushed
the
fix-yfm-table-floating
branch
from
68c55e2 to
2a4f6d1
Compare
makhnatkin
reviewed
Dec 5, 2025
| const rect = (tableNode as Element).getBoundingClientRect(); | ||
| table.style.width = rect.width + 'px'; | ||
| const tableNode = view.domAtPos(tableDesc.pos + 1).node; | ||
| isHorizontallyScrolled = (tableNode as Element).scrollLeft > 0; |
Collaborator
There was a problem hiding this comment.
Suggested change
| isHorizontallyScrolled = (tableNode as Element).scrollLeft > 0; | |
| isHorizontallyScrolled = tableNode instanceof Element && tableNode.scrollLeft > 0; |
makhnatkin
approved these changes
Dec 5, 2025
| isHorizontallyScrolled = (tableNode as Element).scrollLeft > 0; | ||
|
|
||
| const tbodyNode = view.domAtPos(tableDesc.bodyPos + 1).node; | ||
| const tbodyRect = (tbodyNode as Element).getBoundingClientRect(); |
| // left border of table | ||
| if (cellMiddle - EDGE_OFFSET <= tableRect.left) { | ||
| const visible = cellRect.right - tableRect.left; | ||
| cellRect.width = (visible - EDGE_OFFSET) * 2; |
Collaborator
There was a problem hiding this comment.
There's a potential issue when the cell is barely visible: visible - EDGE_OFFSET can become negative, leading to negative width values.
I suggest clamping the adjusted value
const visible = cellRect.right - tableRect.left;
const adjusted = Math.max(0, visible - EDGE_OFFSET);
cellRect.width = adjusted * 2;
Collaborator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed positions of plus buttons
Details
Fixed positions of row and column controls
Details
Fixed row dragging
Details