perf: avoid redundant work in redactSensitiveHeaders on each call#113
Merged
melikhov-dev merged 1 commit intomainfrom Mar 2, 2026
Merged
perf: avoid redundant work in redactSensitiveHeaders on each call#113melikhov-dev merged 1 commit intomainfrom
melikhov-dev merged 1 commit intomainfrom
Conversation
Move headersWithSensitiveUrlsLowered and redactSensitiveKeys outside the inner closure so they are computed once at initialization time rather than on every invocation of redactSensitiveHeaders.
resure
approved these changes
Mar 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
prepareSensitiveHeadersRedacterreturns a closure (redactSensitiveHeaders) that is called on every incoming request. Inside that closure, two expensive operations were being repeated unnecessarily on each invocation:headersWithSensitiveUrls.map(name => name.toLowerCase())— rebuilds the lowercased array every callprepareSensitiveKeysRedacter(sensitiveHeaders)— creates a new redacter function with a new closure every callBoth inputs (
sensitiveHeaders,headersWithSensitiveUrls) are fixed at the timeprepareSensitiveHeadersRedacteris called and never change afterward.Fix
Move both computations to the outer factory function scope, so they run once at initialization rather than on every request.
Test plan
npm test)