Skip to content

fix: slider dots classname #1380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
qradle-yndx merged 2 commits into from
Feb 17, 2026
+15 −7
Merged

fix: slider dots classname #1380

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ca750ae
fix: slider dots classname
qradle-yndx Feb 16, 2026
996d442
fix: update media image slider screenshots
qradle-yndx Feb 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file modified ...al.test.tsx-snapshots/Media-render-stories-ImageSlider-light-chromium-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ...sual.test.tsx-snapshots/Media-render-stories-ImageSlider-light-webkit-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
9 changes: 4 additions & 5 deletions src/blocks/Slider/Slider.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@ $fullscreenArrowArea: 120px;
}
}

$dotsCn: '.swiper-container-horizontal .swiper-pagination-bullets';
$wrapperCn: '.swiper-wrapper';

$dotSize: 8px;
Expand Down Expand Up @@ -191,7 +190,7 @@ $dotSize: 8px;

padding: 0;

& #{$dotsCn} {
#{$root}__dots {
bottom: $indentSM;
}

Expand Down Expand Up @@ -224,7 +223,7 @@ $dotSize: 8px;
}
}

& #{$dotsCn} {
#{$root}__dots {
left: $indentSM;
width: calc(100% - $indentSM);
}
Expand All @@ -242,7 +241,7 @@ $dotSize: 8px;
position: relative;
}

& #{$dotsCn} {
#{$root}__dots {
bottom: $indentM;
}

Expand Down Expand Up @@ -336,7 +335,7 @@ $dotSize: 8px;
height: 100vh;
margin: 0;

& .swiper-pagination {
#{$root}__dots {
bottom: 11px;
}

Expand Down
1 change: 1 addition & 0 deletions src/blocks/Slider/Slider.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,7 @@ export const SliderBlock = ({
enabled: dots,
isA11yControlHidden,
controlTabIndex,
horizontalClass: b('dots'),
bulletClass: b('dot', dotsClassName),
bulletActiveClass: b('dot_active'),
paginationLabel: i18n('pagination-label'),
Expand Down
12 changes: 10 additions & 2 deletions src/blocks/Slider/useSliderPagination.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ export const useSliderPagination = (props: {
enabled: boolean;
isA11yControlHidden: boolean;
controlTabIndex: number;
horizontalClass: string;
bulletClass: string;
bulletActiveClass: string;
paginationLabel: string;
Expand All @@ -14,14 +15,21 @@ export const useSliderPagination = (props: {
return undefined;
}

const {isA11yControlHidden, controlTabIndex, bulletClass, bulletActiveClass, paginationLabel} =
props;
const {
isA11yControlHidden,
controlTabIndex,
bulletClass,
bulletActiveClass,
horizontalClass,
paginationLabel,
} = props;

return {
pagination: {
clickable: true,
bulletClass,
bulletActiveClass,
horizontalClass,
},
onPaginationUpdate: (slider) => {
const pagination = slider.pagination.el;
Expand Down