fix: copyClipboard #2432
Open
fix: copyClipboard #2432
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgaponov
approved these changes
Sep 12, 2025
Contributor
|
Preview is ready. |
ogonkov
reviewed
Sep 12, 2025
| if (typeof navigator !== 'undefined' && navigator.clipboard?.writeText) { | ||
| try { | ||
| return navigator.clipboard.writeText(text); | ||
| navigator.clipboard.writeText(text); |
Contributor
There was a problem hiding this comment.
How this solves the problem?
Contributor
There was a problem hiding this comment.
writeText returns a Promise, so if it fails normally (security issue) we'll never get into the catch block and run fallback
Contributor
There was a problem hiding this comment.
I guess this should we async/await function to work correctly indeed
Contributor
|
Visual Tests Report is ready. |
Yanseses
force-pushed
the
bugfix/2421
branch
from
f65d792 to
ed113eb
Compare
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2421