Skip to content

fix(Select): add correct paddings to avoid cutting off content #2488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(Select): add correct paddings to avoid cutting off content #2488

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 16 additions & 4 deletions src/components/Select/components/SelectControl/SelectControl.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,25 +11,29 @@ $blockButton: '.#{variables.$ns}select-control__button';
--_--text-right-padding: #{select-css-variables.$s-hor-padding};
--_--border-radius: var(--g-border-radius-s);
height: #{variables.$s-height};
padding: 4px calc(var(--_--text-right-padding) + 1px); // plus border-width
padding-inline: calc(var(--_--text-right-padding) + 1px); // plus border-width
padding-block: 4px;
}
@if $size == 'm' {
--_--text-right-padding: #{select-css-variables.$m-hor-padding};
--_--border-radius: var(--g-border-radius-m);
height: #{variables.$m-height};
padding: 6px calc(var(--_--text-right-padding) + 1px); // plus border-width
padding-inline: calc(var(--_--text-right-padding) + 1px); // plus border-width
padding-block: 6px;
}
@if $size == 'l' {
--_--text-right-padding: #{select-css-variables.$l-hor-padding};
--_--border-radius: var(--g-border-radius-l);
height: #{variables.$l-height};
padding: 10px calc(var(--_--text-right-padding) + 1px); // plus border-width
padding-inline: calc(var(--_--text-right-padding) + 1px); // plus border-width
padding-block: 10px;
}
@if $size == 'xl' {
--_--text-right-padding: #{select-css-variables.$xl-hor-padding};
--_--border-radius: var(--g-border-radius-xl);
height: #{variables.$xl-height};
padding: 12px calc(var(--_--text-right-padding) + 1px); // plus border-width
padding-inline: calc(var(--_--text-right-padding) + 1px); // plus border-width
padding-block: 12px;
}
}

Expand Down Expand Up @@ -144,18 +148,26 @@ $blockButton: '.#{variables.$ns}select-control__button';

&_size_s {
@include block_button_style(s);

padding-block: 4px;
}

&_size_m {
@include block_button_style(m);

padding-block: 6px;
}

&_size_l {
@include block_button_style(l);

padding-block: 10px;
}

&_size_xl {
@include block_button_style(xl);

padding-block: 12px;
}

&_error::before {
Expand Down
Loading